Skip to content

switch to bun and place example in workspace#38

Open
reeceyang wants to merge 3 commits intomainfrom
reece/bun-workspace
Open

switch to bun and place example in workspace#38
reeceyang wants to merge 3 commits intomainfrom
reece/bun-workspace

Conversation

@reeceyang
Copy link
Copy Markdown
Contributor

@reeceyang reeceyang commented Feb 24, 2026 •
edited by coderabbitai Bot
Loading

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Summary by CodeRabbit

  • Chores
    • Added workspace support to enable an example monorepo layout.
    • Switched project tooling and lifecycle scripts to use Bun-based commands for development, build, lint, codegen and release workflows (no user-facing behavior changes).

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 24, 2026 •
edited
Loading

Warning

Rate limit exceeded

@reeceyang has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 47 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 0fadde4 and bf99532.

📒 Files selected for processing (1)
  • .github/workflows/test.yml
📝 Walkthrough

Walkthrough

Adds a top-level workspaces entry pointing to "example" and replaces many npm-script invocations with bun equivalents across package scripts (dev, setup, build, codegen, lint, release and related lifecycle scripts). No other files were modified.

Changes

Cohort / File(s) Summary
Package manifest
package.json		 Added workspaces: ["example"]. Replaced multiple npm-based script commands with bun equivalents across dev, predev, setup, build, codegen, lint, release and lifecycle scripts. Minor restructuring of several script command implementations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I swapped my npm shoes for bun,
Hopped into "example" for fun,
Scripts now sprint with a brighter sun,
One tidy workspace, work well done,
Thump-thump — the rabbit’s build is run!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main changes: switching build orchestration to bun and restructuring the example into a workspace configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch reece/bun-workspace

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 24, 2026 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/get-convex/expo-push-notifications/@convex-dev/expo-push-notifications@38

commit: bf99532

@reeceyang
Copy link
Copy Markdown
Contributor Author

reeceyang commented Feb 24, 2026

I think the current weird convex-test typing error is a package resolution issue, so switching to using workspaces should solve that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@reeceyang